Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to polling when RPC fails #226

Merged
merged 2 commits into from
May 26, 2024

Conversation

debendraoli
Copy link
Collaborator

This pull request adds a fallback mechanism to switch to polling when the RPC fails. This ensures that the application can continue functioning even if the RPC connection is lost.

@debendraoli debendraoli self-assigned this May 26, 2024
@debendraoli debendraoli changed the title "Fallback to polling when RPC fails" fix: fallback to polling when RPC fails May 26, 2024
@debendraoli debendraoli added bug Something isn't working enhancement New feature or request Centralised Relay labels May 26, 2024
Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure i understand, if the WS fails once will it poll infidelity?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 26, 2024
@debendraoli
Copy link
Collaborator Author

Not sure i understand, if the WS fails once will it poll infidelity?

Here is the check and the next block is incremented sequently.

@debendraoli
Copy link
Collaborator Author

Polling happens only if there are missing blocks and stopped when reached to the latest block in that recovered period.

Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okeys sounds good, if you are confident i'd say create a release and we can test it out. Can't be much more problems. But lets only test in and push it to the lydia labs relay. Since the foundation one seem to be working fine

@debendraoli debendraoli merged commit 7213dc1 into main May 26, 2024
5 checks passed
@debendraoli debendraoli deleted the refactor/rpc-failure-recovery branch May 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Centralised Relay documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants